From d4e06fd586897cebc6cd458405ef5086450ca479 Mon Sep 17 00:00:00 2001
From: Jukka Lampikoski <jukka@lampikoski.com>
Date: Fri, 13 Mar 2026 14:56:38 +0200
Subject: [PATCH] Optimize Zammad sync: skip closed tickets in incremental sync
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Incremental sync now excludes closed/merged/removed tickets from query
- Full sync still fetches everything
- Reopened tickets (closed→new/open in Zammad) are handled correctly:
  existing ticket is updated instead of creating duplicate

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 api.php | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/api.php b/api.php
index 4b9853b..a0bd892 100644
--- a/api.php
+++ b/api.php
@@ -281,7 +281,7 @@ class ZammadClient {
     }
 
     /** Hae tikettejä (search API palauttaa kaikki joihin on oikeus) */
-    public function getTickets(array $groupIds = [], int $page = 1, int $perPage = 100, ?string $updatedSince = null): array {
+    public function getTickets(array $groupIds = [], int $page = 1, int $perPage = 100, ?string $updatedSince = null, bool $excludeClosed = false): array {
         if (!empty($groupIds)) {
             $parts = array_map(fn($id) => 'group_id:' . $id, $groupIds);
             $query = '(' . implode(' OR ', $parts) . ')';
@@ -291,6 +291,10 @@ class ZammadClient {
         if ($updatedSince) {
             $query .= ' AND updated_at:>=' . $updatedSince;
         }
+        // Ohita suljetut/merged/removed tiketit nopeuttaakseen synkkausta
+        if ($excludeClosed) {
+            $query .= ' AND NOT (state:closed OR state:merged OR state:removed)';
+        }
         return $this->request('GET', 'tickets/search?query=' . urlencode($query) . '&per_page=' . $perPage . '&page=' . $page . '&expand=true');
     }
 
@@ -5360,12 +5364,13 @@ switch ($action) {
                 }
             }
 
-            // Hae tikettejä Zammadista
+            // Hae tikettejä Zammadista (inkrementaalinen: ohita suljetut nopeuttamiseksi)
+            $excludeClosed = !$fullSync;
             $allTickets = [];
             $page = 1;
             $maxPages = $fullSync ? 10 : 3;
             do {
-                $batch = $z->getTickets($groupIds, $page, 100, $lastSync);
+                $batch = $z->getTickets($groupIds, $page, 100, $lastSync, $excludeClosed);
                 if (empty($batch)) break;
                 $allTickets = array_merge($allTickets, $batch);
                 $page++;